Open
Conversation
Member
|
@fpereira1 I've send you an invite to the org, so hopefully I don't need to approve the workflows anymore. |
- Reduced logging verbosity from 'info' to 'error' in wdio.conf.ts - Fixed test isolation by scoping DOM queries to component container - Added cleanup() after each test to prevent state leaking between tests - All existing tests now pass with improved isolation
Member
Author
|
@christian-bromann this isn't a fully passing build (there was a lot broken in this repo) but I think there are some good changes here and I'd like to see this work reviewed/merged. Thank you |
Member
|
What do you think is still broken? |
Member
Author
|
I was hoping to get CI passing in this PR but it's going to take more work
to get everything passing, in this PR, I fixed some things but not all 🙂
…On Wed, Dec 3, 2025, 7:40 AM Christian Bromann ***@***.***> wrote:
*christian-bromann* left a comment
(webdriverio/component-testing-examples#31)
<#31 (comment)>
What do you think is still broken?
—
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGUAR4P7JT7NVHNIQBSEH337XMKLAVCNFSM6AAAAACHT6PZKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMBTGQ3DQMZQGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed CI. Also bumped all dependencies for the example that was failing. Will attempt to go through and do the same for all others at some point
from: 17 vulnerabilities (8 low, 8 moderate, 1 high)
to: 5 moderate severity vulnerabilities